Skip to content

Conversation

@harrryr
Copy link
Contributor

@harrryr harrryr commented Sep 24, 2024

Issue description:
We will be testing ADOT Java on different CPU architectures to ensure that they run on the specified architecture before release.

Description of changes:
Add option to specify CPU architecture for EC2 tests. If not specified they will default to x86_64/AMD64

  • Update AMI name and architecture filter
  • Update instance type to t4g.micro if using arm64 architecture
  • Update trace to use regex rather than hardcoded value

Rollback procedure:
Revert PR

<Can we safely revert this commit if needed? If not, detail what must be done to safely revert and why it is needed.>

Ensure you've run the following tests on your changes and include the link below:
Test Run: https://github.com/harrryr/aws-application-signals-test-framework/actions/runs/11022177981
Test Run: https://github.com/harrryr/aws-application-signals-test-framework/actions/runs/11042828607

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@harrryr harrryr force-pushed the java-architecture-parameter branch from 1f4ad98 to 7210c09 Compare September 25, 2024 23:45
@harrryr harrryr changed the title Add CPU Architecture Parameter for EC2 Tests Add CPU Architecture Parameter for Java EC2 Tests Sep 26, 2024
@harrryr harrryr merged commit 8e06a16 into aws-observability:main Sep 26, 2024
1 check passed
harrryr added a commit that referenced this pull request Sep 27, 2024
*Issue description:*
Same issue as
[PR](#251)
but for Python

*Rollback procedure:*
Revert

*Test Run*

https://github.com/aws-observability/aws-application-signals-test-framework/actions/runs/11043391940
By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants